space before "(c)" #97103 :-)

firstly, why do we first check the partial slot? What if that type is already allocated, shouldn't we take it? Secondly, I'd really try hard to only use goto for error handling. If you really want to avoid adding an extra indentation level, you can make a new function just for finding a slot.

If the client is prepared to use partial slot (which is not really common - only GDB can do that atm) then we should try the partial for it as most of clients cannot deal with partial slot and we run out of them easily.

Hrm, right, if for some reason the module which can handle partial slot got a full one, prior (which should not happen as it should not ask for slots multiple time without releasing it) and other module released the partial one then it could be possible...

Does it worth over-engineering and complicating a simple lookup function?

Sure, I can introduce a bool found = false; and play with just to avoid the goto, but extra ifs and indentation just makes the code less readable.

I can try to see how it looks..

Alternative: bool found = false; at the top of the function, found = true; break; in line 141, if (i == WIN2_SLOTS && ADSP_DW->partial_page0 == slot_address) { here. Then found = true; in line 148. Then if (!found) return; in line 151.

If I must then:

void adsp_dw_release_slot(void *slot_address)
{
	bool found = false;
	int i;

	if (ADSP_DW->partial_page0 == slot_address) {
		i = ADSP_DW_SLOT_COUNT;
		LOG_DBG("Releasing partial page0 used by %#x", ADSP_DW->descs[i].type);
		found = true;
	} else {
		for (i = 0; i < ADSP_DW_FULL_SLOTS; i++) {
			if (ADSP_DW->slots[i] == slot_address) {
				LOG_DBG("Releasing debug slot %d used by %#x", i,
					ADSP_DW->descs[i].type);
				found = true;
				break;
			}
		}
	}

	if (found) {
		ADSP_DW->descs[i].resource_id = 0;
		ADSP_DW->descs[i].type = ADSP_DW_SLOT_UNUSED;
		ADSP_DW->descs[i].vma = 0;
	}
}

it is certainly correct that being static this variable is only visible in this file, still I'd give it a more descriptive name for easier searching like coredump_slot_addr or similar. Same applies to other files below

OK

should we limit this to ADSP_DW_SLOT_COUNT or to ADSP_DW_SLOT_COUNT - 1?

ADSP_DW_SLOT_COUNT - 1 should be ``ADSP_DW_SLOT_COUNT.

confused - you already have this structure in adsp_debug_window.h?

it is only there if the CONF_INTEL_ADSP_DEBUG_SLOT_MANAGER is not enabled.
No one should have any knowledge on how the debug window is partitioned, they just ask for a slot and use the slot which is assigned to them, that's all they need to know.

In other words: when the slot manager is enabled I want to make sure that no one can side step and hack into the system.

do I understand it correctly, that this function only returns a valid slot index if it already has the desired type? If so, then why the preference? We should never have 2 slots with the same type, so shouldn't matter what the preference is. Just search them all. I don't see a need for that parameter here at all.
Update: oh, I see, this function is also used to find an "unused" slot... That's where you need the preference. This function is called 3 times: twice to find an already allocated slot and once to find a free one. Maybe we could make looking for the existing one a separate function with no preference - even with braces with each if and for it should be like 10 lines of code

but why would we want another function when we can use this? When looking for occupied slot with a given type, yes the preference does not matter, but we eventually still need to check the full slots and the partial anyways.